This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Reduce synchronization in PendingTransactions #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransactions. In particularly getTransactionByHash and notifying listeners of added or removed transactions are no longer in synchronized blocks.
… its components." This reverts commit 3e5966e.
shemnon
reviewed
May 15, 2019
|
|
||
| pendingTransactions.values().stream() | ||
| .filter(transaction -> transaction.getAddedToPoolAt().isBefore(removeTransactionsBefore)) | ||
| .forEach(transaction -> removeTransaction(transaction.getTransaction())); |
There was a problem hiding this comment.
It would be nice if there was some way to assert that the underlying spliterator had the CONCURRENT characteristic before performing. While this is correct (because it is from a ConcurrentHashMap) I am concerned that future alterations may miss this nuance. At least a comment would help.
There was a problem hiding this comment.
If the map ever gets changed back to a non-concurrent map, all the places it's accessed from will be problematic. This is actually the place that kind of mistake will be most obvious because the unit tests will fail with ConcurrentModificationException. The others will just be subtle bugs in the face of multiple threads.
shemnon
approved these changes
May 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Reduce the amount of work
PendingTransactionsdoes inside synchronized blocks to reduce contention.ConcurrentHashMapallowing queries likegetTransactionByHashto be performed without any need for synchronization.